[PATCH] D82464: [AArch64][SVE] Predicate bfloat16 load patterns with HasBF16

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12078-12080
+      (VT != MVT::nxv8bf16 ||
+       static_cast<const AArch64Subtarget &>(DAG.getSubtarget()).hasBF16()) &&
+      "Unsupported type (BF16)");
----------------
c-rhodes wrote:
> nit: maybe it's just me but this hurts my head, can we not just write:
> ```  if (VT == MVT::nxv8bf16)
>     assert(
>         static_cast<const AArch64Subtarget &>(DAG.getSubtarget()).hasBF16() &&
>         "Unsupported type (BF16)");```
I think you should `return SDValue()` here instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82464/new/

https://reviews.llvm.org/D82464