[PATCH] D82193: [OpenMPOpt] ICV macro definitions

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 02:08:39 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:327
+__ICV_DATA_ENV(active_levels, NONE, ZERO)
+__ICV_DATA_ENV(cancel, OMP_CANCELLATION, FALSE)
+__ICV_DATA_ENV(__last, last, LAST)
----------------
Is it possible to use a different name than `FALSE` here, because it will fail to compile if the system headers contain a `FALSE` define? Maybe something like `ICV_FALSE` to avoid conflicts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82193/new/

https://reviews.llvm.org/D82193





More information about the llvm-commits mailing list