[PATCH] D79978: Call Frame Information (CFI) Handling for Basic Block Sections

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 23:59:11 PDT 2020


tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfException.h:70-71
+
+  void beginBasicBlock(const MachineBasicBlock &MBB) override;
+  void endBasicBlock(const MachineBasicBlock &MBB) override;
 };
----------------
wmi wrote:
> They are new functions marked as override, but there are no virtual functions added in the base class.  
It is in the parent patch, D78851 in AsmPrinterHandler.h just like beginFragment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79978/new/

https://reviews.llvm.org/D79978





More information about the llvm-commits mailing list