[PATCH] D82607: [NewPM][BasicAA] Rename basicaa -> basic-aa, add alias

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D82607#2115934 <https://reviews.llvm.org/D82607#2115934>, @ychen wrote:

> In D82607#2115919 <https://reviews.llvm.org/D82607#2115919>, @MaskRay wrote:
>
> > Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script:
> >
> >   arcfilter () {
> >           arc amend
> >           git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
> >   }
> >   
> >
> > `Reviewed By: ` is considered important by some people. Please keep the tag. (I have updated my script to use `--date=now` (setting author date to committer date))
> >
> > `https://reviews.llvm.org/D80978` contains a git pre-push hook to automate this.
>
>
> Quick question: how to generate `Reviewed by` in place with commits that are uploaded by `arc diff`. I have to do `arc patch` to get the `Review by` which is not convenient.


+1.

I'll try to get the pre-push hooks working, although it might be tricky on Windows, and easier to forget to setup since I use multiple git worktrees on multiple machines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82607/new/

https://reviews.llvm.org/D82607