[PATCH] D82618: [MemorySSA] Update comment in PassBuilder

[Yuanfang Chen via Phabricator via llvm-commits]

ychen created this revision.
ychen added a reviewer: asbirlea.
Herald added subscribers: llvm-commits, george.burgess.iv, hiraditya, Prazek.
Herald added a project: LLVM.

Is teaching the LoopFullUnrollPass to preserve MemorySSA very hard or
just impossible?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82618

Files:
  llvm/lib/Passes/PassBuilder.cpp


Index: llvm/lib/Passes/PassBuilder.cpp
===================================================================
--- llvm/lib/Passes/PassBuilder.cpp
+++ llvm/lib/Passes/PassBuilder.cpp
@@ -511,8 +511,7 @@
       std::move(LPM1), EnableMSSALoopDependency, DebugLogging));
   FPM.addPass(SimplifyCFGPass());
   FPM.addPass(InstCombinePass());
-  // The loop passes in LPM2 (IndVarSimplifyPass, LoopIdiomRecognizePass,
-  // LoopDeletionPass and LoopFullUnrollPass) do not preserve MemorySSA.
+  // The loop passes in LPM2 (LoopFullUnrollPass) do not preserve MemorySSA.
   // *All* loop passes must preserve it, in order to be able to use it.
   FPM.addPass(createFunctionToLoopPassAdaptor(
       std::move(LPM2), /*UseMemorySSA=*/false, DebugLogging));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82618.273574.patch
Type: text/x-patch
Size: 747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200626/2ce3a15b/attachment.bin>