[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

[Amy Kwan via Phabricator via llvm-commits]

amyk marked 2 inline comments as done.
amyk added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:18
+  // CHECK-NEXT: ret <4 x i32>
+  return vec_dive(vsia, vsib);
+}
----------------
anil9 wrote:
> I may be wrong but where are the variables declared ? I do not see the variables delclared above in the file, i mean many of them.
I accidentally uploaded the wrong diff, I will update this. 


================
Comment at: llvm/test/CodeGen/PowerPC/p10-vector-divide.ll:49
 }
+
+declare <4 x i32> @llvm.ppc.altivec.vdivesw(<4 x i32>, <4 x i32>)
----------------
anil9 wrote:
> nit : you put a comment right at this position in the multiply.ll file, for consistency you could add one here or remove the one there. 
Will fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82609/new/

https://reviews.llvm.org/D82609