[PATCH] D82514: Remove references to the 4.0 release as a major breaking (NFC)

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 15:51:09 PDT 2020


echristo added inline comments.


================
Comment at: llvm/lib/IR/DataLayout.cpp:263
     case 's':
       // Ignored for backward compatibility.
       break;
----------------
mehdi_amini wrote:
> echristo wrote:
> > dexonsmith wrote:
> > > I think @echristo is suggesting updating this comment to match the new ones elsewhere ("Deprecated, but ...").
> > I was yes :)
> Ah OK.
> 
> This isn't bitcode related though: we have a few occurrences of these in the LL parser as well that I didn't touch. I don't think there is a policy on these, what should I write?  `// Deprecated, but ignoring here to preserve loading older textual llvm ASM file` ?
Works for me :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82514/new/

https://reviews.llvm.org/D82514





More information about the llvm-commits mailing list