[PATCH] D82590: [NewPM][LoopUnroll] Rename unroll* to loop-unroll*

Thu Jun 25 15:51:08 PDT 2020

aeubanks marked an inline comment as done.
aeubanks added inline comments.

================
Comment at: llvm/lib/Passes/PassRegistry.def:274
 #endif
 FUNCTION_PASS_WITH_PARAMS("unroll",
                            [](LoopUnrollOptions Opts) {
----------------
aeubanks wrote:
> dmgreen wrote:
> > It's called "unroll". So why would it not be called "unroll-and-jam"?
> > (I have no real opinion on one vs the other, but seems more consistent to use a name similar to the unroll pass)
> I kept going back and forth on which one to use. Other related passes are named the same way, "loop-unroll-*" in legacy PM and "unroll-*" in NPM. I think having the "loop-" prefix is clearer, and also would require cleaning up fewer tests.
> I can clean up each pass separately.
Never mind I just did it all here, can you take a look again?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82590/new/

https://reviews.llvm.org/D82590