[PATCH] D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC)

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 15:18:15 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/docs/CodingStandards.rst:1617
+  if (isa<VarDecl>(D)) {
+    for(auto *A : D.attrs())
+      if (shouldProcessAttr(A))
----------------
Add a space after `for`. ditto below for at least two other instances.


================
Comment at: llvm/docs/CodingStandards.rst:1657
+  if (auto *D = dyn_cast<FunctionDecl>(D)) {
+    if(shouldProcess(D))
+      handleVarDecl(D);
----------------
Add a space after `if`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82594/new/

https://reviews.llvm.org/D82594





More information about the llvm-commits mailing list