[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

Thu Jun 25 15:18:13 PDT 2020

sbc100 accepted this revision.
sbc100 added a comment.

Linker changes still lgtm % comments

================
Comment at: lld/wasm/InputChunks.cpp:338

+  auto WASM_OPCODE_PTR_CONST =
+      config->is64 ? WASM_OPCODE_I64_CONST : WASM_OPCODE_I32_CONST;
----------------
sbc100 wrote:
> Just use normal variable names here?  `opcode_const` and `opcode_add`?
Normal variable names?

================
Comment at: lld/wasm/InputChunks.cpp:363
+
+    auto is64 = relocIs64(rel.Type);
+    auto opcode_const =
----------------
Again I think you appetite for the use of auto is exceeding that of the llvm coding style...  I tend to stick to cases where the type is spelled out later in the same line.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82130/new/

https://reviews.llvm.org/D82130