[PATCH] D82590: [NewPM][LoopUnrollAndJam] Rename unroll-and-jam to loop-unroll-and-jam

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 14:11:56 PDT 2020


dmgreen added inline comments.


================
Comment at: llvm/lib/Passes/PassRegistry.def:274
 #endif
 FUNCTION_PASS_WITH_PARAMS("unroll",
                            [](LoopUnrollOptions Opts) {
----------------
It's called "unroll". So why would it not be called "unroll-and-jam"?
(I have no real opinion on one vs the other, but seems more consistent to use a name similar to the unroll pass)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82590/new/

https://reviews.llvm.org/D82590





More information about the llvm-commits mailing list