[PATCH] D82588: [DSE] Look through memory PHI arguments when removing noop stores in MSSA.

Thu Jun 25 13:05:26 PDT 2020

fhahn added a comment.

In D82588#2115091 <https://reviews.llvm.org/D82588#2115091>, @zoecarver wrote:

> Also, `MultiSource/Applications/SPASS/SPASS.test` is failing for some reason. The error it's giving me is:
>
>   /Users/zoe/Developer/llvm-source/stats-build/tools/fpcmp-target: files differ without tolerance allowance
>
>
> It looks like this may be an issue with the time it took to execute the test? That may be because I'm running these tests on a laptop (so both compile time and execution time aren't going to be accurate metrics).

Does it pass without the patch? If it only fails with the patch, the patch is likely introducing a mis-compile.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82588/new/

https://reviews.llvm.org/D82588