[PATCH] D82580: [RegisterCoalescer] Dumper for JoinVals

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin marked an inline comment as done.
vpykhtin added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveInterval.cpp:1028
       if (vnum) OS << ' ';
-      OS << vnum << '@';
-      if (vni->isUnused()) {
-        OS << 'x';
-      } else {
-        OS << vni->def;
-        if (vni->isPHIDef())
-          OS << "-phi";
-      }
+      vni->print(OS);
     }
----------------
arsenm wrote:
> vpykhtin wrote:
> > arsenm wrote:
> > > It should print each on a different line?
> > No, why?
> You manually corrected the output to make it readable, since the one line is way too long. Why not just print it that way?
I was trying to keep the style of dump it currently have, having less lines on output. I agree it much easier to read it formatted on different lines, so I'll probable change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82580/new/

https://reviews.llvm.org/D82580