[PATCH] D81760: [WebAssembly] Add warnings for -shared and -pie

Thu Jun 25 12:29:11 PDT 2020

sunfish marked 4 inline comments as done.
sunfish added inline comments.

================
Comment at: lld/wasm/Driver.cpp:469
+    if (config->shared) {
+      warn("shared libraries are not yet implemented");
+    }
----------------
sbc100 wrote:
> Since this is just a warning and linker will actual produce a binary.. how about something like like :  "the shared library is not yet stable"?      Or some other wording to that effect.
> 
> This wording sounds like it would be hard error and not output anything.
Changed to  say "not yet stable".

================
Comment at: lld/wasm/Options.td:204
+// Emscripten PIC mode.
+def emscripten_pic: F<"emscripten-pic">,
+  HelpText<"Enable Emscripten-style PIC">;
----------------
sbc100 wrote:
> I'm a little loath to explicitly call out emscripten.   We could use some term like "experimental" or "v1" or something similar?   
> 
> Once argument for this the emscripten ABI is actually quite different to the output of lld.    We use a binaryen transforms which transforms the lld output, for example it internalizes/removes all the GOT imports that lld generates.     
Changed to experimental.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81760/new/

https://reviews.llvm.org/D81760