[PATCH] D82580: [RegisterCoalescer] Dumper for JoinVals

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveInterval.cpp:1028
       if (vnum) OS << ' ';
-      OS << vnum << '@';
-      if (vni->isUnused()) {
-        OS << 'x';
-      } else {
-        OS << vni->def;
-        if (vni->isPHIDef())
-          OS << "-phi";
-      }
+      vni->print(OS);
     }
----------------
It should print each on a different line?


================
Comment at: llvm/lib/CodeGen/RegisterCoalescer.cpp:3334-3335
 
+  LLVM_DEBUG(dbgs() << "\t\tRHSVals "; RHSVals.dump(); dbgs() << '\n');
+  LLVM_DEBUG(dbgs() << "\t\tLHSVals "; LHSVals.dump(); dbgs() << '\n');
+
----------------
Merge to one LLVM_DEBUG block


================
Comment at: llvm/lib/CodeGen/RegisterCoalescer.cpp:3429-3430
 
+  LLVM_DEBUG(dbgs() << "\t\tRHSVals "; RHSVals.dump(); dbgs() << '\n');
+  LLVM_DEBUG(dbgs() << "\t\tLHSVals "; LHSVals.dump(); dbgs() << '\n');
+
----------------
Merge to one LLVM_DEBUG block


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82580/new/

https://reviews.llvm.org/D82580