[PATCH] D82565: Fix invalid alignment in DAGCombiner::isLegalNarrowLdSt

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 08:34:30 PDT 2020


gchatelet marked an inline comment as done.
gchatelet added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4879
+  if (ShAmt) {
+    assert(ShAmt % 8 == 0 && "ShAmt is byte offset");
+    const unsigned ByteShAmt = ShAmt / 8;
----------------
`assert` here is just to refresh what is established L.4861
It helps understand why `ShAmt / 8` is valid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82565/new/

https://reviews.llvm.org/D82565





More information about the llvm-commits mailing list