[PATCH] D82203: [FileCheck] Implement -dump-input-context and -dump-input-filter

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D82203#2113046 <https://reviews.llvm.org/D82203#2113046>, @Meinersbur wrote:

> To reduce the amount the output, could the input dump be restricted to the range between two labels? The rationale is that those ranges are logically independent blocks (such as a function) and the mismatch should be contained within such a block.


Do you mean this as an alternative to the patch under review?  As others have pointed out <http://lists.llvm.org/pipermail/llvm-dev/2020-June/142392.html>, the range between two labels can be large, and sometimes there are no labels and the input is large.  Either way, its seems that restricting the dump to the range between two labels would often not solve the verbosity problem people are reporting, so I don't think that should be the default behavior.  The patch under review should do better at limiting the verbosity per error.

Do you instead mean this as an additional opt-in feature?  I'm not opposed if people feel that would be helpful, but I think it should be a later review.  It might be enabled by `-dump-input-context=label`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82203/new/

https://reviews.llvm.org/D82203