[PATCH] D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl()

Thu Jun 25 06:53:19 PDT 2020

emaste added a comment.

some nitpick comments. I'm not familiar with z/OS's APIs here so not qualified to fully review the change in `getMainExecutable` but seems reasonable

================
Comment at: llvm/lib/Support/Unix/Path.inc:53

+#ifdef __MVS__
+#include <sys/ps.h>
----------------
this should probably be part of the `#ifdef`/`#elif` block?

================
Comment at: llvm/lib/Support/Unix/Path.inc:68

+#if defined(__MVS__) && !defined(PATH_MAX)
+#define PATH_MAX _XOPEN_PATH_MAX
----------------
Maybe this?
```
#if !defined(PATH_MAX)
# if defined(__GNU__)
#  define PATH_MAX 4096
# elif defined(__MVS__)
#  define PATH_MAX _XOPEN_PATH_MAX
# endif
#endif
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82544/new/

https://reviews.llvm.org/D82544