[PATCH] D82464: [AArch64][SVE] Predicate bfloat16 load patterns with HasBF16
Cullen Rhodes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 25 05:47:27 PDT 2020
c-rhodes added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12078-12080
+ (VT != MVT::nxv8bf16 ||
+ static_cast<const AArch64Subtarget &>(DAG.getSubtarget()).hasBF16()) &&
+ "Unsupported type (BF16)");
----------------
nit: maybe it's just me but this hurts my head, can we not just write:
``` if (VT == MVT::nxv8bf16)
assert(
static_cast<const AArch64Subtarget &>(DAG.getSubtarget()).hasBF16() &&
"Unsupported type (BF16)");```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82464/new/
https://reviews.llvm.org/D82464
More information about the llvm-commits
mailing list