[PATCH] D77152: [SelectionDAG] Better legalization for FSHL and FSHR

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6289
-        return;
-      }
-
----------------
foad wrote:
> RKSimon wrote:
> > @foad We've lost this functionality - this needs adding to the new expansion code or to DAGCombiner
> ` TargetLowering::expandROT` does this: "// If a rotate in the other direction is supported, use it." Are there tests showing that it's not working for some reason?
Yes the AMDGPU/fshl.ll tests look like they've regressed because of this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77152/new/

https://reviews.llvm.org/D77152