[PATCH] D82451: [AMDGPU] Fix DPP Combiner:

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 04:42:33 PDT 2020


vpykhtin added a comment.

In D82451#2113831 <https://reviews.llvm.org/D82451#2113831>, @foad wrote:

> > 1. skip multiple per instruction DPP register usage.
> > 2. don't combine when DPP register is used as part of superreg/supersubreg.
> > 
> >   I had to refactor the code to fix the first issue,
>
> Would it make sense to split this patch into two or three? Refactoring, fix bug 1, fix bug 2?


Yes, if there're no other objections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82451/new/

https://reviews.llvm.org/D82451





More information about the llvm-commits mailing list