[PATCH] D82274: [llvm-objcopy] Emit error if removing symbol table referenced by SHT_GROUP section

[Georgy Komarov via Phabricator via llvm-commits]

jubnzv updated this revision to Diff 273264.
jubnzv marked 4 inline comments as done.
jubnzv added a comment.

I agree, this makes it cleaner.

I also found a strange behavior of `{{.*}}` regex in group.test. It seems that it doesn't match an empty sequence.

For example, when I trying to match the second line here (empty `Flg` field):

  [Nr] Name              Type            Address          Off    Size   ES Flg Lk Inf Al
  [ 1] .group            GROUP           0000000000000000 000040 000008 04     0  0   4

This regex works as expected:

  # SECTIONS-NEXT: .group    {{.+}} {{.+}}  {{.+}} {{.+}} {{.+}}     0  0

But this one doesn't match the line:

  # SECTIONS-NEXT: .group    {{.+}} {{.+}}  {{.+}} {{.+}} {{.+}} {{.*}} 0  0


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82274/new/

https://reviews.llvm.org/D82274

Files:
  llvm/test/tools/llvm-objcopy/ELF/group.test
  llvm/tools/llvm-objcopy/ELF/Object.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82274.273264.patch
Type: text/x-patch
Size: 4419 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200625/501c1a5f/attachment.bin>