[PATCH] D82503: [llvm-objcopy][MachO] Fix segment size alignment

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 01:35:48 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/segment-size-alignment.test:59
+## xcrun -sdk iphoneos clang -arch armv7 main.c -o main.exe
+--- !mach-o
+FileHeader:
----------------
Do we really need such verbose inputs for the test case? This test is purely about the segment address/size values. Everything else seems to be noise to me, and makes it hard to identify what in the input YAML is actually important.

I'm not convinced it's important for the input to be a fully runnable executable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82503/new/

https://reviews.llvm.org/D82503





More information about the llvm-commits mailing list