[PATCH] D82214: [SVE] Remove calls to VectorType::getNumElements from AArch64
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 25 01:03:18 PDT 2020
david-arm added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9642
- VectorType *VecTy = Shuffles[0]->getType();
+ auto *VecTy = Shuffles[0]->getType();
----------------
Hi @ctetreau, could you not just cast Shuffles[0]->getType() to a FixedVectorType here, then avoid having to make the two typecasts below? That way if it is indeed a scalable vector it will blow up earlier, perhaps in a more obvious place?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82214/new/
https://reviews.llvm.org/D82214
More information about the llvm-commits
mailing list