[PATCH] D81236: Improve LegacyPassManager API to correctly report modified status

[Ehud Katz via Phabricator via llvm-commits]

ekatz added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/LoopExtractor.cpp:135
+  bool Changed = false;
+  LoopInfo &LI = getAnalysis<LoopInfoWrapperPass>(F, &Changed).getLoopInfo();
 
----------------
jdoerfert wrote:
> ekatz wrote:
> > Maybe I am missing something, but isn't `LoopExtractor` dependent on `BreakCriticalEdges`? I mean, what are the transformations that the `LoopInfo` analysis depends on?
> > what are the transformations that the LoopInfo analysis depends on?
> 
> No transformations:
> 
> ```
>   void LoopInfoWrapperPass::getAnalysisUsage(AnalysisUsage &AU) const {                                                                                                                                              
>     AU.setPreservesAll();
>     AU.addRequiredTransitive<DominatorTreeWrapperPass>();
>   }
>   
> ```
So why would the `Changed` ever be set to `true`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81236/new/

https://reviews.llvm.org/D81236