[PATCH] D82455: [yaml2obj] - Add a way to set default values for macros used in a YAML.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Thanks for looking at this. I've had a few times where this might have been useful already. Do we need a way of escaping the `=` in the event somebody wants to explicitly include it? Not sure I can think of a use-case for that, so probably not, but something to think about.

LGTM, with @MaskRay's comments and one nit addressed.



================
Comment at: llvm/tools/yaml2obj/yaml2obj.cpp:83
+
+        // When the -D option is requested, we use a value provided.
+        // Otherwise we use a default macro value if any is present
----------------
a value provided -> the provided value


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82455/new/

https://reviews.llvm.org/D82455