[PATCH] D82463: [AMDGPU] Spill more than wavesize CSR SGPRs

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/spill_more_than_wavesize_csr_sgprs.ll:10
+define void @spill_more_than_wavesize_csr_sgprs() {
+  call void asm sideeffect "",
+   "~{s35},~{s36},~{s37},~{s38},~{s39},~{s40},~{s41},~{s42}
----------------
arsenm wrote:
> You removed the stack object, but my point was without your patch, this already works:
> 
> 	v_writelane_b32 v0, s98, 63
> 	v_writelane_b32 v1, s99, 0
> 	v_writelane_b32 v1, s100, 1
> 
> So that means this test should include with and without the stack object. We also need to solve the mystery of why this stack object is needed
Without the stack object FuncInfo->VGPRReservedForSGPRSpill is 0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82463/new/

https://reviews.llvm.org/D82463