[PATCH] D82435: [DWARFYAML][debug_gnu_*] Add the missing context `IsGNUStyle`. NFC.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 18:29:36 PDT 2020


Higuoxing marked an inline comment as done.
Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/DWARFYAML.cpp:51
 void MappingTraits<DWARFYAML::Data>::mapping(IO &IO, DWARFYAML::Data &DWARF) {
+  auto *OldContext = IO.getContext();
+  DWARFYAML::DWARFContext DWARFCtx;
----------------
> @jhenderson : Let's be explicit about the type here. It's not obvious to me from looking at this what the type returned by getContext is.

`IO.getContext()` returns `void *`. It might be a `MachOYAML::Object&` or a `ELFYAML::Object&` here. I guess we cannot cast it to an explicit type here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82435/new/

https://reviews.llvm.org/D82435





More information about the llvm-commits mailing list