[PATCH] D82511: [NewPM] Move debugging log printing after PassInstrumentation before-pass-callbacks

[Yuanfang Chen via Phabricator via llvm-commits]

ychen created this revision.
ychen added reviewers: echristo, fedor.sergeev, chandlerc, asbirlea.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

For passes got skipped, this is confusing because the log said it is `running pass`
but it is skipped later.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82511

Files:
  llvm/include/llvm/IR/PassManager.h


Index: llvm/include/llvm/IR/PassManager.h
===================================================================
--- llvm/include/llvm/IR/PassManager.h
+++ llvm/include/llvm/IR/PassManager.h
@@ -503,9 +503,6 @@
 
     for (unsigned Idx = 0, Size = Passes.size(); Idx != Size; ++Idx) {
       auto *P = Passes[Idx].get();
-      if (DebugLogging)
-        dbgs() << "Running pass: " << P->name() << " on " << IR.getName()
-               << "\n";
 
       // Check the PassInstrumentation's BeforePass callbacks before running the
       // pass, skip its execution completely if asked to (callback returns
@@ -513,6 +510,10 @@
       if (!PI.runBeforePass<IRUnitT>(*P, IR))
         continue;
 
+      if (DebugLogging)
+        dbgs() << "Running pass: " << P->name() << " on " << IR.getName()
+               << "\n";
+
       PreservedAnalyses PassPA;
       {
         TimeTraceScope TimeScope(P->name(), IR.getName());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82511.273190.patch
Type: text/x-patch
Size: 921 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200624/cd7e1482/attachment.bin>