[PATCH] D82488: [NewPM] Separate out alias analysis passes in opt

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

A general comment on the series of patches: it's great to have this means of testing the NPM through the legacy way of specifying passes, but I believe the long term goal is to only rely on specifying via `passes=...`. Most tests will need to be updated to get there, so having this mass testing available now is very useful!
Just note that when the transition is made to only use `passes=...` to opt, all additions made solely for matching the legacy `-foo-pass` arguments will need to be cleaned up (e.g. the API added here in `PassBuilder.h`)



================
Comment at: llvm/tools/opt/NewPMDriver.cpp:314
   }
+  // For compatibility with legacy pass manager.
+  // Alias analyses are not specially specified when using the legacy PM.
----------------
Could you assert AAPipeline and AA passes inside `Passes` don't co-exist?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82488/new/

https://reviews.llvm.org/D82488