[PATCH] D82500: [llvm-profdata] --hot-func-list: fix some style issues in D81800
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 24 15:13:38 PDT 2020
MaskRay added a comment.
In D82500#2112631 <https://reviews.llvm.org/D82500#2112631>, @wenlei wrote:
> For the use of `auto`, is there extra convention except what's said here? https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable
>
> It feels the style convention is a bit loose though, except those enforced by linter.
I feel so. For longer type names like `std::pair<..., ...>` or `std::map<...>::iterator` people don't typically write the underlying type. I agree with such practice. However, in this file, when we can write a single identifier instead `auto` , I think we should stick with the rule.
> (FYI this is the original diff: https://reviews.llvm.org/D81800)
Thanks. Corrected the title.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82500/new/
https://reviews.llvm.org/D82500
More information about the llvm-commits
mailing list