[PATCH] D82432: [lld-macho] Use namespace qualifiers (macho::) instead of `namespace lld { namespace macho {`

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 14:40:38 PDT 2020


MaskRay added a comment.

In D82432#2112587 <https://reviews.llvm.org/D82432#2112587>, @int3 wrote:

> @MaskRay this seems to have broken the build on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16604/steps/stage%201%20build/logs/stdio


Should have been fixed by 40bc99538c85904e3f4de04c795bbebd4013bbe7 <https://reviews.llvm.org/rG40bc99538c85904e3f4de04c795bbebd4013bbe7>  (hope reducing `using namespace` can be accepted)

Sorry for the breakage!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82432/new/

https://reviews.llvm.org/D82432





More information about the llvm-commits mailing list