[PATCH] D81728: [InstCombine] Add target-specific inst combining

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D81728#2112558 <https://reviews.llvm.org/D81728#2112558>, @arsenm wrote:

> In D81728#2112483 <https://reviews.llvm.org/D81728#2112483>, @craig.topper wrote:
>
> > In D81728#2112158 <https://reviews.llvm.org/D81728#2112158>, @arsenm wrote:
> >
> > > In D81728#2111901 <https://reviews.llvm.org/D81728#2111901>, @craig.topper wrote:
> > >
> > > > As far as I know and I might be wrong, but TargetTransformInfo up til now has only provided information. It doesn't do any transforms itself. Is adding transforms to it the right thing to do?
> > >
> > >
> > > This isn't strictly true. I recently added rewriteIntrinsicWithAddressSpace for example
> >
> >
> > I stand corrected then.
>
>
> This may be the only example though. I may have introduced something conceptually new without realizing it. The current use also doesn't exactly make the change. It does introduce new instructions, but the pass is still responsible for doing the replacement/delete of the old value


I guess it also modifies the original instruction in place in some cases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81728/new/

https://reviews.llvm.org/D81728