[PATCH] D82031: [scudo][standalone] Release smaller blocks less often
Kostya Kortchinsky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 24 13:34:44 PDT 2020
cryptoad added a comment.
In D82031#2112360 <https://reviews.llvm.org/D82031#2112360>, @cferris wrote:
> Overall, this seems to be reasonable, but I am a bit worried about the odd 32 bit performance. Is there an explanation for what could be causing the 32 bit calls to increase?
Hmm this shouldn't be the case:
- The primary changes will release the memory less often, so there shouldn't be an impact on runtime.
- The packed counter array size change is a bug that would make us use the static buffer less often, so we are saving some mmap calls there.
- The clear() addition to the batch pre-destroying only matters when trying to reclaim transfer batches which happens only on a forced release.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82031/new/
https://reviews.llvm.org/D82031
More information about the llvm-commits
mailing list