[PATCH] D82488: [NewPM] Separate out alias analysis passes in opt

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 13:34:41 PDT 2020


ychen added a comment.

LGTM with one nit.



================
Comment at: llvm/include/llvm/Passes/PassBuilder.h:520
+  ///
+  /// For compatibility with legacy pass manager.
+  bool isAAPassName(StringRef PassName);
----------------
`/// For compatibility with legacy pass manager.` I would move this above the introduced loop in opt.cpp. Probably adding something like `AA analyses are not specified separately when using legacy PM`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82488/new/

https://reviews.llvm.org/D82488





More information about the llvm-commits mailing list