[PATCH] D82405: [openmp] Move Directive and Clause helper function to tablegen

Wed Jun 24 13:34:37 PDT 2020

jdoerfert added a comment.

In D82405#2112451 <https://reviews.llvm.org/D82405#2112451>, @clementval wrote:

> In D82405#2112272 <https://reviews.llvm.org/D82405#2112272>, @jdoerfert wrote:
>
> > So the idea is we generate a single .inc file with multiple `ifdef` regions to choose from? Is that what is usually done? I would have thought multiple files are nicer but no strong feeling.
>
>
> I have no strong opinion on this as well. MLIR is generating two files for their dialects (1 ``.h.inc` and `.cpp.inc) but use the sections as well. We will probably need the sections as well even if we do two or more files.

Why do we need sections if we generate multiple files?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82405/new/

https://reviews.llvm.org/D82405