[PATCH] D82496: [amdgpu] Add codegen support for HIP dynamic shared memory.

Wed Jun 24 13:34:36 PDT 2020

arsenm requested changes to this revision.
arsenm added a comment.
This revision now requires changes to proceed.

Needs to handle globalisel too.

I also thought we were trying to get rid of group static size. It's broken with LDS relocations which we need to move towards. Can we just switch directly to using a relocation here?

================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5523
+        GV->hasExternalLinkage()) {
+      ArrayType *ATy = dyn_cast<ArrayType>(GV->getValueType());
+      if (ATy && ATy->getNumElements() == 0) {
----------------
Why does it specifically need to be a 0 sized array? I think this would depend purely on the linkage, or treat any 0 sized type the same way

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82496/new/

https://reviews.llvm.org/D82496