[PATCH] D82270: Added a Printer to the FunctionPropertiesAnalysis

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 13:01:42 PDT 2020


jdoerfert added a comment.

In D82270#2111884 <https://reviews.llvm.org/D82270#2111884>, @mtrofin wrote:

> Sounds like we need the Info's self-refreshing ability to support old-PM scenarios, correct? If I understand it correctly, there, the Info object could be retrieved from the analysis (this'd be an old-PM analysis, to be added), and then the client could refresh it without the involvement of the analysis or analysis manager, but updating the state the Analysis manager. Is that even desirable?


Its for the old-PM scenario but there is no need for the result to be self-refreshing. The key point is that the analyze method is shared, thus not part of the new-PM pass. If we want a immutable result we can again create a `Result` class in the `FunctionPropertiesInfo`. I don't mind that either way as long as `analyze` (and `print`) logic is outside of `FunctionPropertiesAnalysis` I'm happy. Does that make sense?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82270/new/

https://reviews.llvm.org/D82270





More information about the llvm-commits mailing list