[PATCH] D82479: [llvm-size] Output REL, RELA and STRTAB sections in some cases

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 12:28:35 PDT 2020


MaskRay added a comment.

> I'm not sure always outputting these sections is correct, below is a diff for a potential change that does not copy the complex rules:

I am questioning why omitting these sections in considered incorrect.  SHT_STRTAB is not usually SHF_ALLOC. If we can find cases where GNU size -A emits SHT_REL and SHT_RELA, we can delete the three lines:

  case ELF::SHT_STRTAB:
  case ELF::SHT_REL:
  case ELF::SHT_RELA:

even if we can't delete `SHT_SYMTAB` and `SHT_NULL`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82479/new/

https://reviews.llvm.org/D82479





More information about the llvm-commits mailing list