[PATCH] D82280: Fix for NVPTX module asm regression

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 10:15:40 PDT 2020


tra added a comment.

>   I did not add a unit test as one was added in commit d2bbdf05e0b88524226589d89ffb2bfdc53ef3c8 but without calling ptxas -v on every emitted ptx file we can't not verify the correctness

Before I land the test, we do need to fix test/CodeGen/NVPTX/module-inline-asm.ll as it did not detect the current issue.
The test currently only verifies the presence of the module-level inline assembly in the output, but it does not verify that it's in the right place or that it's only emitted once.

We heed few more checks that the inline assembly is only emitted after the initial PTX directives and before the functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82280/new/

https://reviews.llvm.org/D82280





More information about the llvm-commits mailing list