[PATCH] D82480: [FileCheck][NFC] Remove redundant DumpInputDefault

[Joel E. Denny via Phabricator via llvm-commits]

jdenny created this revision.
jdenny added reviewers: probinson, thopre, jhenderson, mehdi_amini.
Herald added a project: LLVM.
jdenny added a child revision: D82203: [FileCheck] Implement -dump-input-context and -dump-input-filter.

I cannot find a reason to keep DumpInputDefault.  Anyone else?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82480

Files:
  llvm/utils/FileCheck/FileCheck.cpp


Index: llvm/utils/FileCheck/FileCheck.cpp
===================================================================
--- llvm/utils/FileCheck/FileCheck.cpp
+++ llvm/utils/FileCheck/FileCheck.cpp
@@ -110,7 +110,6 @@
 // The order of DumpInputValue members affects their precedence, as documented
 // for -dump-input below.
 enum DumpInputValue {
-  DumpInputDefault,
   DumpInputNever,
   DumpInputFail,
   DumpInputAlways,
@@ -551,7 +550,7 @@
                               "FILECHECK_OPTS");
   DumpInputValue DumpInput =
       DumpInputs.empty()
-          ? DumpInputDefault
+          ? DumpInputFail
           : *std::max_element(DumpInputs.begin(), DumpInputs.end());
   if (DumpInput == DumpInputHelp) {
     DumpInputAnnotationHelp(outs());
@@ -668,9 +667,6 @@
                             InputFileText, InputFile.getBufferIdentifier()),
                         SMLoc());
 
-  if (DumpInput == DumpInputDefault)
-    DumpInput = DumpInputFail;
-
   std::vector<FileCheckDiag> Diags;
   int ExitCode = FC.checkInput(SM, InputFileText,
                                DumpInput == DumpInputNever ? nullptr : &Diags)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82480.273081.patch
Type: text/x-patch
Size: 1119 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200624/f7a702fb/attachment-0001.bin>