[PATCH] D80765: [ELF] Handle bitcode comdat groups separately to deduplicate thinlto comdat sections

[Christy Lee via Phabricator via llvm-commits]

christylee marked an inline comment as done.
christylee added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:611
+      // Else, check all comdat groups.
+      bool isNew = isLTOOutput
+                       ? symtab->ltoOutputComdatGroups
----------------
@MaskRay 
>  Since .debug_types (notably, a non-SHF_ALLOC section) is the only COMDAT rule this patch will discard, how about special casing .debug_types (i.e. if isLTOOutput && the group is related to .debug_types)?

At the time we run this check, not all InputSections have been initialized, so a the group might be related to an uninitialized section.  Since it might be uninitialized, what's the best way to check if that section is non-SHF_ALLOC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80765/new/

https://reviews.llvm.org/D80765