[PATCH] D82469: Take out resource tracking from ASM printer.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 09:09:30 PDT 2020


arsenm added a comment.

I don't see where else this could be validly used?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.h:80
 public:
+  std::shared_ptr<SIFunctionResourceInfoTracker> ResourceTracker;
   explicit AMDGPUAsmPrinter(TargetMachine &TM,
----------------
There's basically never a need for shared_ptr. unique_ptr is almost always better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82469/new/

https://reviews.llvm.org/D82469





More information about the llvm-commits mailing list