[PATCH] D82433: [ELF] -r: don't parse @ (symbol versioning) for .symver inline asm in bitcode
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 24 08:36:51 PDT 2020
MaskRay added inline comments.
================
Comment at: lld/test/ELF/lto/version-script2.ll:14
+; CHECK: UND bar{{$}}
+; CHECK-NEXT: [[#SHNDX:]] foo@@VER1
+
----------------
grimar wrote:
> This defines `SHNDX` which is never used I think. Why just you didn't use a section index instead?
The variable name cannot be omitted:
```
% cat a.txt
CHECK: [[#%u:]]
% FileCheck a.txt
a.txt:1:11: error: invalid variable name
CHECK: [[#%u:]]
^
```
I'll use `{{` instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82433/new/
https://reviews.llvm.org/D82433
More information about the llvm-commits
mailing list