[PATCH] D70365: intrinsics attribute opt-out list proposal.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:120
 
+def IntrNoFree : IntrinsicProperty;
+
----------------
This should be spilt to a separate change


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:352
+
+  list<IntrinsicProperty> IntrProperties = !listconcat(intr_properties, default_properties);
   let Properties = sd_properties;
----------------
I think this strategy doesn't actually work, given the prevalence of the error prone global let blocks. I've fixed many bugs from let Soemthing in :{} sections overwriting the inner members. I think the only way short of redesigning the language to have some kind of additive let to add to lists, I think the safest way to do this is to have tablegen handle the opt-out list


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70365/new/

https://reviews.llvm.org/D70365