[PATCH] D81911: [IR] Fix getBaseObject for GlobalAlias-to-GlobalIFunc

[Dmitry Polukhin via Phabricator via llvm-commits]

DmitryPolukhin added a comment.

In D81911#2111204 <https://reviews.llvm.org/D81911#2111204>, @nextsilicon-itay-bookstein wrote:

> Doesn't that mean that GlobalIFunc shouldn't really inherit from GlobalIndirectSymbol (and then GlobalIndirectSymbol loses the justification for its existence)?
>  I get the feeling like there's an expectation for getBaseObject to be idempotent (since it pierces through ConstantExprs and GlobalAliases), but GlobalIndirectSymbol::getBaseObject takes the resolver (getOperand(0)) and performs the lookup on it.


GlobalIndirectSymbol doesn't mean to be an alias. GlobalIFunc doesn't inherit from GlobalAliases that would be wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81911/new/

https://reviews.llvm.org/D81911