[PATCH] D82454: [ADT] Add Bitfield utilities - design #3

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet created this revision.
gchatelet added reviewers: courbet, serge-sans-paille, rriddle.
gchatelet added a project: LLVM.
Herald added subscribers: llvm-commits, dexonsmith, mgorny.
gchatelet edited the summary of this revision.

Alternative design to D81580 <https://reviews.llvm.org/D81580> with the following change in API

  before: using Bool = Bitfield<bool, 0, 1>;
  after:  using Bool = Bitfield::Element<bool, 0, 1>;
  
  // testField becomes cast to bool operator
  
  before: if(Bool::testField(Storage))
  after:  if(Bitfield::test<Bool>(Storage))
  
  // getField becomes cast to UserType
  before: auto Value = Bool::getField(Storage);
  after:  auto Value = Bitfield::get<Bool>(Storage);
  
  // setField becomes returning a UserType assignable object
  before: Bool::setField(Storage, Value);
  after:  Bitfield::set<Bool>(Storage, Value);


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82454

Files:
  llvm/include/llvm/ADT/Bitfields.h
  llvm/unittests/ADT/BitFieldsTest.cpp
  llvm/unittests/ADT/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82454.272989.patch
Type: text/x-patch
Size: 20163 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200624/e0bb6b30/attachment.bin>