[PATCH] D82453: [CostModel] Fix for cast crash

[Sam Parker via Phabricator via llvm-commits]

samparker created this revision.
samparker added reviewers: Carrot, uabelho.
Herald added subscribers: zzheng, hiraditya.
Herald added a project: LLVM.

Don't assume that the 'NextLevelOp' is an instruction.

Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=46430


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82453

Files:
  llvm/lib/Analysis/TargetTransformInfo.cpp
  llvm/test/Transforms/LoopUnroll/X86/pr46430.ll


Index: llvm/test/Transforms/LoopUnroll/X86/pr46430.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/LoopUnroll/X86/pr46430.ll
@@ -0,0 +1,23 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -mtriple=x86_64-unknown-linux-gnu -loop-unroll -costmodel-reduxcost -S -o - %s | FileCheck %s
+
+define void @g() {
+; CHECK-LABEL: @g(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    br label [[F_EXIT:%.*]]
+; CHECK:       f.exit:
+; CHECK-NEXT:    [[RDX_SHUF9_I:%.*]] = shufflevector <4 x i16> <i16 1, i16 0, i16 undef, i16 undef>, <4 x i16> undef, <4 x i32> <i32 1, i32 undef, i32 undef, i32 undef>
+; CHECK-NEXT:    [[BIN_RDX10_I:%.*]] = xor <4 x i16> <i16 1, i16 0, i16 undef, i16 undef>, [[RDX_SHUF9_I]]
+; CHECK-NEXT:    [[TMP0:%.*]] = extractelement <4 x i16> [[BIN_RDX10_I]], i32 0
+; CHECK-NEXT:    br label [[F_EXIT]]
+;
+entry:
+  br label %f.exit
+
+f.exit:                                           ; preds = %f.exit, %entry
+  %rdx.shuf9.i = shufflevector <4 x i16> <i16 1, i16 0, i16 undef, i16 undef>, <4 x i16> undef, <4 x i32> <i32 1, i32 undef, i32 undef, i32 undef>
+  %bin.rdx10.i = xor <4 x i16> <i16 1, i16 0, i16 undef, i16 undef>, %rdx.shuf9.i
+  %0 = extractelement <4 x i16> %bin.rdx10.i, i32 0
+  br label %f.exit
+}
+
Index: llvm/lib/Analysis/TargetTransformInfo.cpp
===================================================================
--- llvm/lib/Analysis/TargetTransformInfo.cpp
+++ llvm/lib/Analysis/TargetTransformInfo.cpp
@@ -1054,7 +1054,7 @@
 
   // Check that the next levels binary operation exists and matches with the
   // current one.
-  if (Level + 1 != NumLevels) {
+  if (Level + 1 != NumLevels && isa<Instruction>(NextLevelOp)) {
     Optional<TTI::ReductionData> NextLevelRD =
         getReductionData(cast<Instruction>(NextLevelOp));
     if (!NextLevelRD || !RD->hasSameData(*NextLevelRD))
@@ -1076,8 +1076,10 @@
     return RD->Kind;
 
   // Match next level.
-  return matchPairwiseReductionAtLevel(cast<Instruction>(NextLevelOp), Level,
-                                       NumLevels);
+  if (isa<Instruction>(NextLevelOp))
+    return matchPairwiseReductionAtLevel(cast<Instruction>(NextLevelOp), Level,
+                                         NumLevels);
+  return TTI::RK_None;
 }
 
 TTI::ReductionKind TTI::matchPairwiseReduction(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82453.272980.patch
Type: text/x-patch
Size: 2378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200624/9c550e1f/attachment.bin>