[PATCH] D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare

[serge via Phabricator via llvm-commits]

serge-sans-paille marked 2 inline comments as done.
serge-sans-paille added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:4955
   if (!AddrModes.combineAddrModes()) {
-    TPT.rollback(LastKnownGood);
-    return false;
+    return TPT.changed(LastKnownGood);
   }
----------------
foad wrote:
> The commit message suggests you're just fixing the return value from optimizeMemoryInst, but this change (not rolling back) looks like a change in behaviour. Can you explain?
Thanks for spotting this - it was an error.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81256/new/

https://reviews.llvm.org/D81256