[PATCH] D82435: [DWARFYAML][debug_gnu_*] Add the missing context `IsGNUStyle`. NFC.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 03:12:40 PDT 2020


jhenderson added a comment.

In D82435#2110942 <https://reviews.llvm.org/D82435#2110942>, @Higuoxing wrote:

> In D82435#2110862 <https://reviews.llvm.org/D82435#2110862>, @jhenderson wrote:
>
> > You need some form of testing for this. You might want to use Mach-O for testing it in this case.
>
>
> Unfortunately, yaml2macho doesn't support emitting the .debug_gnu_pub* sections :-(
>  What about using unit test here?


If it's straightforward, unit-testing would always be my preference. If not, just rebase your other patch on this one, to show that the fix actually fixes it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82435/new/

https://reviews.llvm.org/D82435





More information about the llvm-commits mailing list